now-u / now-u-campaigns

now-u website

https://now-u.com

2 stars 6 forks source link

Feat/blog search #92

Closed shah-tejas closed 4 years ago

shah-tejas commented 4 years ago

Description

Implements Search feature for the blogs. Allows to filter blogs based on selected campaigns.

Trello Link: Implement Search Dropdown Fixes #93

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have reviewed the 'files changed' tab on github to ensure all changes are expected
[x] I have added someone to review the pr

shah-tejas commented 4 years ago

When I open the dropdown It just seems to show an empty small white square

Yes, that is due to the campaigns url not fetching the respective campaigns, for which blogs exist.

JElgar commented 4 years ago

ah 🤣

shah-tejas commented 4 years ago

@JElgar Fixed it now. Fetching old campaigns, and appending them to the new campaigns. Dropdown works fine now.

JElgar commented 4 years ago

I just spotted this but I don't know if that's related to this pr? And similarly, on the right-hand side it says "This month campaign" opposed to "this month's campaigns" and then show all the campaigns instead of just this months.

Also this seems to happen on smaller screens

stellenberger commented 4 years ago

Thank you for this - looks great!

Regarding the blog dropdown menu, is there a scroll feature added to this?

At the moment if I untick all the available choices, there are still some blogs showing, which makes me think that some of the checkboxes are hidden from view (plus bottom checkbox is cut a little shorter)?

Screenshot 2020-09-02 at 08 48 05

EDIT: Line 52 of searchDropdown.module.scss is overflow: hidden If you set this to overflow:scroll, this should solve the problem. I cant do a commit suggestion as this line of code was not amongst the lines changed in this PR

shah-tejas commented 4 years ago

Hi @JElgar & @stellenberger,

Apologies for the delay in addressing the review comments! I have addressed the following -

This Month's Campaigns now shows only this month's campaigns
Fixed the typo with "This Month's Campaign"
Center aligned the App Download div
Added the vertical scroll bar on the SearchDropdown on overflow

Thank you for catching these, I had missed them and hopefully these should now be fixed!