User can create a reference

[iritmaximus]

• [x] User without writing rights cannot create a reference
• [x] User with writing rights can create a reference with valid inputs
• [x] User with writing rights and incorrect input cannot create a reference and is notified about it
• [x] User with writing rights and incorrect input is notified about it
• [x] Tests are implemented
• [x] Documentation is written

[juhanikat]

Started in sprint 2, continued in sprint 3

[kaarleol]

Continued in sprint 4

[karilint]

Test results:

• [] Partly OK: User without writing rights cannot create a reference If normal www-user tries a link for a new reference, the page is displayed although nothing is saved: https://nowdb-frontend-nowdatabase.ext.ocp-test-0.k8s.it.helsinki.fi/reference/new?tab=0

• [x] OK: User with writing rights can create a reference with valid inputs

• [ ] Not OK: User with writing rights and incorrect input cannot create a reference and is notified about it

• [ ] Not OK: User with writing rights and incorrect input is notified about it

• [x] Possibly OK: Tests are implemented

• [x] OK: Documentation is written

• already entered data is not visible if missing values exist

  • Create a new Reference (journal)
  • add title and press "Save changes"
  • error "Following validators failed: date_primary" is displayed
  • title is empty

• Journal: currently only informs "Following validators failed: title_primary, date_primary" Journal must have Authors or Editors of Issue and surname and initials fields must be set. Enter Title, Title of Issue, Series Title or Notes. Enter Year in numerical format YYYY Journal is required.

• Book: currently only informs "Following validators failed: title_primary, date_primary" Book must have Authors, Editors or Series Editors and surname and initials fields must be set. Enter Title, Series Title or Notes. Enter Year in numerical format YYYY.

  • when selecting the editors, the UI asks to select "Authors"

• all other types Please check all different types and check from PHP all the required fields

Reference:

• Heading should be something like "Berggren et al. (1985). Cenozoic Geochronology. Geological Society of America Bulletin 96: 1407-1418."
  • now it is just "Cenozoic Geochronology"
• missing Locality tab
• missing species tab

[kaarleol]

Ready for Kari's review

[karilint]

Test results: Not approved

Journal: Journal must have Authors or Editors of Issue and surname and initials fields must be set.

• One time, when I selected two authors and then deleted one, the Authors section is surrounded by red although there still remains one author and Editors section is red (I wasn't able to replicate this later)
• Editors: Add new/Select Editor not Author Enter Title, Title of Issue, Series Title or Notes.
• now it seems that only Title is marked as required

Book: Book must have Authors, Editors or Series Editors and surname and initials fields must be set.

• Editors: Add new/Select Editor not Author Enter Title, Series Title or Notes.
• now it seems that only Title is marked as required

Electronic Citation:

• has wrong info text for required fields (see below)

Internet Communication:

• Author -> Sender, Recipient

Personal Communication:

• Author -> Recipient

Undefined:

• Otsikkoina title_primary yms. (see below)

• in general, the red border is too thin - hard to notice it

• after creating a Reference succesfully, the browser tab shows "New reference" it could show something similar like when you have opened a Locality (usually only "References" is shown on the tab)

• all the info's for missing data should have "display values", not the table column names, i.e. At least one of the following fields must have text: title_primary, gen_notes -> Title, Notes

[juhanikat]

Thank you. These are tracked in the following tasks:

582

583

584

585

586

587

588

Journal must have Authors or Editors of Issue and surname and initials fields must be set.

Does this mean you don't need both Authors and Editors, or does there have to be at least one of both types?