search

nowendwell / laravel-terms

A tool for adding terms and conditions to your project
MIT License
23 stars 8 forks source link

Implement Spatie PackageServiceProvider #9

Closed cyrillkalita closed 3 years ago

cyrillkalita commented 3 years ago

@nowendwell is that what you meant?

If I may, I would suggest 2 things:

  1. Let's make middleware optional, enabled by default. Either an array of middleware groups to automatically register for, or boolean to register for 'web'
  2. Add LaravelTerms::class as a singleton (as seen in #8 )

This is untested yet. Let me know

nowendwell commented 3 years ago

Yeah, I like the idea of the middleware in there but just always running the happy path. I think I'll move the existing AcceptedTerms body into the readme as an example.