Closed trufae closed 7 years ago
done
On 10 Feb 2017, at 02:45, Ole André Vadla Ravnås notifications@github.com wrote: @oleavr requested changes on this pull request. Awesome! Just one small nit: In index.js https://github.com/nowsecure/frida-trace/pull/4#pullrequestreview-21165012: @@ -268,6 +274,28 @@ function int() { }; } +function byte() { Could we move these up so they match the order at the top? (byte, short, then int) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nowsecure/frida-trace/pull/4#pullrequestreview-21165012, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIjG_eS0dmvg-vehKK00FPlZBogSMeCks5ra8FMgaJpZM4L7G3U.
On 10 Feb 2017, at 02:45, Ole André Vadla Ravnås notifications@github.com wrote:
@oleavr requested changes on this pull request.
Awesome! Just one small nit:
In index.js https://github.com/nowsecure/frida-trace/pull/4#pullrequestreview-21165012:
@@ -268,6 +274,28 @@ function int() { }; }
+function byte() { Could we move these up so they match the order at the top? (byte, short, then int)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nowsecure/frida-trace/pull/4#pullrequestreview-21165012, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIjG_eS0dmvg-vehKK00FPlZBogSMeCks5ra8FMgaJpZM4L7G3U.
done