search

nowsecure / fsmon

monitor filesystem on iOS / OS X / Android / FirefoxOS / Linux
https://www.nowsecure.com
MIT License
881 stars 151 forks source link

Fix signal handler #16

Closed elfring closed 8 years ago

elfring commented 8 years ago

The function "printf" does not belong to the list of async-signal-safe functions. How do you think about to delete its call from your function "control_c"?

trufae commented 8 years ago

Should be fixed now in master, thanks for reporting!

elfring commented 8 years ago

Which commit should have fixed this issue?

trufae commented 8 years ago

the big refactoring one, aka 54919306cdd539266c664bd9cdd355182dc99ba9

in fact you can remove the printf in there because its already handled in the outer loop. so just removing those 3 lines was enough

On 01 May 2016, at 21:12, Markus Elfring notifications@github.com wrote:

Which commit should have fixed this issue?

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/nowsecure/fsmon/issues/16#issuecomment-216065080

elfring commented 8 years ago

Are there more implementation details to reconsider?