nowsecure / fsmon

monitor filesystem on iOS / OS X / Android / FirefoxOS / Linux
https://www.nowsecure.com
MIT License
881 stars 151 forks source link

Completion of error handling #17

Closed elfring closed 6 years ago

elfring commented 8 years ago

Would you like to add more error handling for return values from functions like the following?

trufae commented 8 years ago

sure, will do before 1.2 release

trufae commented 8 years ago

i'm not using signal anymore. sigaction works better. no return value checks yet. will update the code later

trufae commented 8 years ago

checked return values for alarm and sigaction

trufae commented 8 years ago

handling return values for all printf/fprintf calls will mess too much the code and i think the benefits for this are low, so i'm moving this issue to 1.3 for now.

trufae commented 8 years ago

See f8e666d4b272876202e21f41252e2e198283db98

elfring commented 8 years ago

I suggest to avoid ignorance of return values a bit more.

Are you interested to apply aspect-oriented software development? How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

trufae commented 6 years ago

let's close this for now, we'll see if there's any other missing return value that is not checked properly

elfring commented 6 years ago

There were update candidates left over.