search

nowthis / sankeymatic

Make Beautiful Flow Diagrams
http://sankeymatic.com/build/
ISC License
841 stars 122 forks source link

Allow docker build #62

Closed jrottenberg closed 7 months ago

jrottenberg commented 1 year ago

So it's simpler to test and deploy.

Let me know if you are interested in a GitHub action to push the image to ghcr.io

nowthis commented 1 year ago

@jrottenberg Hi and thanks for the PR.

I am generally aware that Docker is a way to package a small custom build which can then be deployed many places, but I have not yet personally used it.

Can you help me understand what this specific addition would help with?

jrottenberg commented 1 year ago

Oh it could help user to use the system, with docker you could actually test the tool without having node, git even installed and run it with a : 

docker run -p 8000:80 sankeymatic

and get a working Sankeymatic build interface on

http://localhost:8000/build/

Of course once the image is published (and kept up to date with a github action), users can start deploying on more production ready infrastructure (kubernetes, ecs). Because it's all client side with javascript, the image itself is very lightweight , and quite easy to make : https://hub.docker.com/search?q=sankeymatic

We have 3 on docker hub, it's all good, Yay opensource, but it will help if we had an authoritative image, that is automated (github action or similar)