nowthis
commented
2 months ago @maxstanley Thanks for putting this together, but I've decided not to add it to this repository.
It's basically outside the scope of my project & what I am comfortable committing to maintain.
My primary goal is to provide interesting sample code and share/show my work so that others may find useful things in it (and submit features or fixes if they are so inclined). Making it easy to set up many copies of the tool isn't on my roadmap of features I'm hoping to get to.
More importantly: if I incorporate this change and then anything breaks with it (say, there's a syntax change for Actions, or when some other change I implement accidentally breaks this), then I will be on the hook to fix it since it's part of my own repository, and I would rather spend that energy/time on features and fixes for the tool itself.
(You may well ask: why then is there a Dockerfile PR that I did accept? Good question. If that PR arrived today, I don't think I would accept it now either. And if that Dockerfile starts to require its own troubleshooting down the line, I'm more likely to remove it than troubleshoot it, as making this Docker-friendly is not in scope for me.)
All of that said: if you want to maintain a fork that adds this Action (and handle future problems when it breaks), I don't object.
This PR is intended to provide a mechanism to be able to mirror this repository offline and deploy with a local Pages deployment.
This would also allow you to test changes online before deploying the changes to your site.
The output of this PR can be viewed here https://maxstanley.github.io/sankeymatic/
Thank you for all your work.