noxdafox / pebble

Multi threading and processing eye-candy.
GNU Lesser General Public License v3.0
537 stars 52 forks source link

Include worker PID in ProcessExpired exception #141

Open rsiemens opened 1 month ago

rsiemens commented 1 month ago

👋 , we are utilizing the pebble ProcessPool quite heavily and occasionally we'll find ourselves needing to debug an abnormal exit on a worker. When ProcessExpired is raised in the main processes done_callback we get the exit code, which is helpful, but lack the process id of the worker which would make finding logs and sourcing the underlying reason much easier.

Ask:

noxdafox commented 1 month ago

Hello,

thanks for reporting this issue. I will add the PID onto the exception.

charettes commented 1 month ago

Thanks for your consideration @noxdafox 🙇 Would submitting a PR with tests tweaks ourselves be appreciated or you'd prefer to tackle the feature request yourself?

I see there's already a test we could adjust for this purpose