search

noxdafox / rabbitmq-cloudwatch-exporter

RabbitMQ Plugin for publishing cluster metrics to AWS CloudWatch
Mozilla Public License 2.0
42 stars 9 forks source link

Support for IMDSV2 #33

Closed avivek closed 2 years ago

avivek commented 3 years ago

We have been using this plugin to capture the RMQ metrics @ cloudwatch for quite some time and it has been working great. Thanks a lot.

About the Enhancement: The IMDS of AWS has a new version IMDSV2. AWS recommends that everyone migrate to the V2 version, and has settings to turn off V1 at the machine level. This is recommended for security reasons.

The peer_discovery_aws module has moved over: https://github.com/rabbitmq/rabbitmq-server/pull/2952

Also when I checked on the Dependency of this project ex_aws, there is a PR that is open for this: https://github.com/ex-aws/ex_aws/pull/739

It would be really helpful if we could support this enhancement for this library.

noxdafox commented 3 years ago

I am not sure IMDS related changes have to do with this plugin. This plugin simply uses ex_aws to interface with AWS APIs.

The way ex_aws authenticates with AWS is out of the scope for this plugin. Is there some necessary changes to be done once said PR get merged?

avivek commented 3 years ago

When the IMDSV2 is supported on the ex_aws library, we need to upgrade the dependency here. I think nothing else is required.

avivek commented 2 years ago

Hi @noxdafox the IMDSV2 supported has been merged by the ex_aws library. Please refer to the below PR:

https://github.com/ex-aws/ex_aws/pull/860

Can you please update the dependency and create a release for this.

avivek commented 2 years ago

Hi @noxdafox,

The IMDSV2 supported has been merged by the ex_aws library. Please refer to the below PR:

https://github.com/ex-aws/ex_aws/pull/860

Can you please update the dependency and create a release for this.

noxdafox commented 2 years ago

Resolved in v1.0.4