noxdafox / rabbitmq-message-deduplication

RabbitMQ Plugin for filtering message duplicates
Mozilla Public License 2.0
271 stars 33 forks source link

Fix typo of Mnesia storage_type #105

Closed gomoripeti closed 5 months ago

gomoripeti commented 7 months ago

Plugin used to crash in a distributed cluster when a node was added to the cache replicas because Mnesia.add_table_copy/3 was called with invalid table storage type argument.

node 'rabbit@node-02' up
** Generic server 'Elixir.RabbitMQMessageDeduplication.CacheManager' terminating
** Last message in was {mnesia_system_event,
                           {mnesia_up,'rabbit@node-02'}}
** When Server state == #{}
** Reason for termination ==
** {{case_clause,
        {aborted,
            {badarg,cache_exchange_<name>,
                ram_nodes}}},
    [{'Elixir.RabbitMQMessageDeduplication.Cache',
         '-cache_rebalance/1-fun-0-',4,
noxdafox commented 7 months ago

Hey!

Thanks for your contribution! I am struggling with the test suite right now. As soon as I get the tests to run I will validate and merge!

noxdafox commented 5 months ago

Finally managed to fix the build logic. I will test it and release during WE. Thanks again for your contribution!

noxdafox commented 5 months ago

Fix release in version 0.6.2.

gomoripeti commented 5 months ago

thank you for maintaining this plugin and the heroic efforts to keep the build/CI working!

noxdafox commented 5 months ago

I would not call it heroic 😁, but it is indeed becoming harder and harder to maintain the plugin unfortunately.