search

noxrepo / pox

The POX network software platform
https://noxrepo.github.io/pox-doc/html/
Apache License 2.0
624 stars 471 forks source link

bug in arp_helper #202

Closed nemethf closed 6 years ago

nemethf commented 6 years ago

This recent commit breaks arp_helper because the use_port_mac argument has been removed form ARPHelper.init(), but at line 237 the corresponding member variable / attribute is still referenced.

Thanks

MurphyMc commented 6 years ago

Hah, well, the commit message warns it may break code, but I don't think that was what I meant. ;) It looks like I just forgot to finish it. I don't have time to test at the moment, but here's a quick pass at fixing it. If it seems to work for you, I'll just push it. Otherwise, I can take another crack at it later.

nemethf commented 6 years ago

Yes, that code fixes the problem for our very simple test-case. Thank you.

MurphyMc commented 6 years ago

Fixed in eel and fangtooth. Thanks for the report and test!

nemethf commented 6 years ago

Thanks again.

(Does fangtooth mean that you happened to find time to work on pox once again? That would be really great news.)

MurphyMc commented 6 years ago

Yeah, POX has been factoring into work again, so it has been getting some attention. My focus hasn't been OpenFlow type stuff, but even that has been getting some work. RIP-on-OVS, OVS bundle action, improvements to discovery, a new and much-improved OpenFlow spanning tree component (spanning_forrest), and the little discovery graph, for example. But I think the mass of stuff is probably not directly OpenFlow-related... GRE, VXLAN, IGMPv3 support in the packet library... config files... lots of improvements/additions to the DHCP and ARP stuff in pox/proto/... a bunch of stuff for working with Linux network interfaces including a revent-based capture API... lots of little fixes and improvements here and there. (Indeed, some of that stuff is actually about making it useful in non-OpenFlow contexts, e.g., the DHCP client code.)

It's still living in my (public) fork, but I'm planning to shift it over to noxrepo one of these days.

In the slightly longer term, I'm planning to finally mainline the ovsdb support I wrote and the edge apps that @garyachy and I worked on a few years ago (oof), though that probably all needs to be tested against modern OVS first, so it might be a while before I get to it.