Values of nw_proto are incorrectly labeled in the comments.

noxrepo / pox

The POX network software platform

https://noxrepo.github.io/pox-doc/html/

Apache License 2.0

619 stars 470 forks source link

Values of nw_proto are incorrectly labeled in the comments. #276

Closed JoeySo22 closed 2 years ago

JoeySo22 commented 2 years ago

Hello,

In dart, I realized that the comments on /pox/pox/openflow/libopenflow_01.py line 1267 are incorrectly labelling the respective values above it.

Says (1, 6, 17) -> TCP/UDP/ICMP

I discovered with dpctl dump-flows that (1, 6, 17) maps to ICMP/TCP/UDP

MurphyMc commented 2 years ago

I don't think it was really meant to imply that 1, 6, 17 corresponded to TCP, UDP, ICMP respectively. The comment isn't really labeling those things -- it's just describing what it means that it's inside the if body.

That said, the earlier version of this code (which I wrote) did have them listed respectively. I've fixed it on the gar branch of my fork. It'll eventually make its way to the gar branch here.