noxworld-dev / opennox

OpenNox main repository.
GNU General Public License v3.0
461 stars 25 forks source link

FoN may stuck in shield and great sword #440

Open dennwc opened 2 years ago

dennwc commented 2 years ago

At least it was reported for vanilla and should have been partially fixed by Mix patch.

The problem was that due to float precision, the orb was stuck bouncing inside the shield. Mix fixed it by despawning the orb. We should first check if we have Mix patch (just look if FoN despawns?) and instead of despawning, increase precision to double.

@Evengard do you remember if you integrated this patch with other Mix changes?

Evengard commented 2 years ago

I tried to integrate the full mix patch decompile, but it was kinda buggy so the related routines could had been lost in limbo... Or just not working correctly even if present. Although I'm unsure if it was actually in mix patch or in UniMod, and I actually start to think it might had been the latter.

dennwc commented 2 years ago

Xandros confirmed that it's in Unimod, not Mix patch:

https://github.com/Evengard/UniMod/blob/master/bugsAndChips.cpp#L373 https://github.com/Evengard/UniMod/blob/master/bugsAndChips.cpp#L374

Also, Zeng mentioned that the same may happen for a Chakram weapon.

dennwc commented 9 months ago

Same happens with reflective shield. image