noxworld-dev / opennox

OpenNox main repository.
GNU General Public License v3.0
463 stars 25 forks source link

Make build work with both Go 1.18 and 1.19 #527

Closed blmarket closed 2 years ago

blmarket commented 2 years ago

Removing quote escape made the build work for both versions. Tested using: 1.18: docker ubuntu:22.04 1.19: Arch linux as host os

Why it works? : I'm not very sure, but the code is using exec.command, which may call syscall exec() family so no escaping is needed. (unlike shell, which parse the command first then call exec)

Fixes #523

Required sign-off