Fix incorrect usage of playerAnimGetFrameRange - Githubissues

noxworld-dev / opennox

OpenNox main repository.

GNU General Public License v3.0

451 stars 25 forks source link

Fix incorrect usage of playerAnimGetFrameRange #567

Closed blmarket closed 1 year ago

blmarket commented 1 year ago

Original C code: https://github.com/noxworld-dev/opennox/blob/fbfe4ab0af102962fef696123c00ea3a581e6c3d/src/GAME4.c#L1879

Can find:

nox_xxx_animPlayerGetFrameRange_4F9F90(..., &v67, &v69); 
nox_xxx_animPlayerGetFrameRange_4F9F90(..., &v69, &v67);

(Had mixed use of v67 and v69)

Which were all ported to same:

v67, v69 := playerAnimGetFrameRange(...)

(second variant were not ported correctly)

This commit fixes params order properly using the order from C code.

Required sign-off

[x] I confirm that my PR does not contain any commercial or protected assets and/or source code.
[x] I agree in advance that my codes will be licensed automatically under the Apache License or similar BSD/MIT-like open source licenses in case if OpenNox Project will adopt such a non-GPL license in the future.

blmarket commented 1 year ago

This will fixes #561, and possibly #562