noxworld-dev / opennox

OpenNox main repository.
GNU General Public License v3.0
440 stars 23 forks source link

Chakrum Over Encumberment Error Messages #697

Open KILAH4716 opened 1 month ago

KILAH4716 commented 1 month ago

https://youtu.be/PpygOgmTN5s

I found this issue in Nox Reloaded. tl;dr: Stop the errors we're obviously not supposed to see from appearing.

I ran into this error a long time ago by sheer accident, and I don't know if I ever posted it on here, so I'm doing it now.

When you throw a Chakrum, the weapon reasonably leaves your inventory to bounce around, and attempts to return to you. When you're over-encumbered, you simply struggle to move until you drop enough things to bring your carry weight below your max capacity. However, what happens when your inventory is FULL?

The errors explain everything. There are 3 errors we're not supposed to see that happens in a sequential order:

  1. That magical device cannot be used by you. This is a standard message a Warrior gets when he picks up a spellbook. This is normal, especially in Quests.

  2. *** ERROR: No room in inventory GUI for item *** The game detects that the Chakrum that magically appeared in our inventory cannot fit in our inventory, so the game needs to drop it immediately.

  3. *** ERROR: Equipped item not found in inventory GUI *** The game is trying to look for the Chakrum for various reasons upon its return to the Warrior, which is supposed to be automatically equipped as a weapon if the Warrior is bare-handed (which he is after throwing the Chakrum), however, because the inventory is full and the game forced the Chakrum to drop immediately, it's not in the player's inventory, so the game can't find it.

  4. You are carrying too much to pick that up. We finally get the common message we get when we try to over encumber our carry weight or inventory space.

  5. *** ERROR: Dropped item not found in inventory GUI *** The game is attempting to eject the item from our inventory with a check it runs behind the scenes, but because the Chakrum was never in our inventory in the first place (since the first error), the game can't find it.

At this point, the game no longer sees this as a problem, and carries on with the rest of the game. The Chakrum drops ontop of your character, and any attempt to pick it up will fail as normal until you can clear inventory space.

However, there are 3 error messages we got that we obviously weren't supposed to see. These messages are designed for the developers during troubleshooting, but because this is a scenario that's rarely seen, this issue slipped under Westwood's radar.

I was wondering if our OpenNox team could clean up these errors so at the very least, we don't see them.