Error in regular expression causing sendmail malfunction

noxxi / p5-io-socket-ssl

IO::Socket::SSL Perl Module

36 stars 59 forks source link

Error in regular expression causing sendmail malfunction #17

Closed apolukhin closed 10 years ago

apolukhin commented 10 years ago

Description of this issue can be found here.

In that thread there is also a solution:

The bug appears to be in line 1490 of /usr/local/share/perl/5.14.2/IO/Socket/SSL.pm.
change:
    m{^(!?)(?:(SSL(?:v2|v3|v23|v2/3))|(TLSv1[12]?))$}i 
to:
    m{^(!?)(?:(SSL(?:v2|v3|v23|v2/3))|(TLSv1[12]?))}i

apolukhin commented 10 years ago

Oops, looks like this was already fixed in https://github.com/noxxi/p5-io-socket-ssl/commit/5c2151176da6a37e7dd16fd2ffc39809f58f6035

noxxi commented 10 years ago

This is and was not a bug in IO::Socket::SSL. The syntax of "SSLv3 TLSv1" is not and was never supported by IO::Socket::SSL and the supported syntax is clearly documented. In older version the syntax used just caused IO::Socket::SSL to silently use only SSLv3 (and not TLSv1), in newer versions it will fail hard with "invalid SSL_version specified".