Remove useless code from Elliptic Curves Regression

noxxi / p5-io-socket-ssl

IO::Socket::SSL Perl Module

36 stars 59 forks source link

Remove useless code from Elliptic Curves Regression #37

Closed toddr closed 8 years ago

toddr commented 8 years ago

I can't determine that this code actually does anything. Looks like it's left over from some old issue??

noxxi commented 8 years ago

Hi, thank for your patch but could you please explain why I should remove this code? It is clearly shown why the code is there, i.e. see the reference to the OpenSSL ticket.

toddr commented 8 years ago

Can you explain what it does? The code:

( Net::SSLeay::OPENSSL_VERSION_NUMBER() != 0x1000104f || length(pack("P",0)) == 4 );

Is a check. I assume this does nothing:

Net::SSLeay::OPENSSL_VERSION_NUMBER() != 0x1000104f

to my knowledge length == 5 seems to do nothing?

toddr commented 8 years ago

oh wow. I'm reading this one more time and realizing the problem. There are comments in the middle of the statement to the point I couldn't tell where the statement began and ended.

rurban commented 8 years ago

Please close this. The issue is easy to understand.