noxxi / p5-io-socket-ssl

IO::Socket::SSL Perl Module
36 stars 60 forks source link

Clean up $self when re-used #57

Closed toddr closed 7 years ago

toddr commented 7 years ago

Hi, I just ran across a failed test in one of our servers which bisected to 7ee0ba3ed24c7c2d47a3258cad09c4153528d69b.

The issue appears to be that you can't delete a slice like that since $self is a hash ref not a hash? I apologize that I can't provide you with a unit test to show this bug. I thought I'd submit the fix first.

noxxi commented 7 years ago

I don't think the fix is correct. As you can see all over the code it should be ${*$self}{...} and not ${*$self}->{...} as in your code which also means that the existing code should be right in my opinion. Please provide a test program to trigger the problem and also the Perl version used so could find out what the problem really is.

toddr commented 7 years ago

Apologies. I misunderstood that the glob was a hash not a hash ref. It's exposing an underlying bug in our code.