noyah81 / p2ducks

2 stars 0 forks source link

Nivu Week 3 #30

Open nivupai opened 3 years ago

nivupai commented 3 years ago

Setting up profile page, backend of Sign-Up page, and link-in between the two.

Setting up profile page and sign-up backend

TLDR:

sarahwxie commented 3 years ago

Hey Nivu! I checked your code, and you've completed all these things & the UI looks really good! Everything is working without bugs which is really nice. Your ticket could be improved by bullet points, but other than that, it looks good.

nivupai commented 3 years ago

Hey Nivu! I checked your code, and you've completed all these things & the UI looks really good! Everything is working without bugs which is really nice. Your ticket could be improved by bullet points, but other than that, it looks good.

Thanks Sarah, I'll do that right now :)

noyah81 commented 3 years ago

Reorganize the ticket to maybe add more details and structure so the the reader understands the purpose (like what the logging in feature is useful for in terms of the theme of our site).

AkhileshLG commented 3 years ago

The ticket looks very well put together. You have a good bit at the end that summarizes it and you have a list of everything that you worked on. You were also very specific about it. I don't really see anything that could be changed. Maybe you can put some future ideas?

meghanakillada commented 3 years ago

The ticket looks good and very detailed. I like how you incorporated checkboxes to show which components you completed and it makes it more organized. I think the ticket can be improved by adding links to code and runtime.

noyah81 commented 3 years ago

Great job on this. I saw the nav bar update it looked way more organized. Specify what parts of the profile will be customizable.

sarahwxie commented 3 years ago

The profile page and backend to the sign up page is working really well! The color scheme looks nice on the website and the backend code has lots of comments to help me understand it.