search

nozavroni / csvelte

🕺🏻 CSV and Tabular Data library for PHP
http://phpcsv.com/
Other
6 stars 0 forks source link

Change name of Resource class #143

Closed nozavroni closed 7 years ago

nozavroni commented 7 years ago

Unfortunately, PHP has seen fit to reserve the word "resource" for future use. So, naming a class "Resource" is, apparently, not such a good idea. So.... I guess I'm going to have to change the name of CSVelte\IO\Resource. Here's a list of options:

Not a single one of them makes me all warm and fuzzy like resource did, but oh well... gotta pick one. Probably gonna go with CSVelte\IO\StreamResource, CSVelte\IO\ResourceObj, CSVelte\IO\ResourceHandle or CSVelte\IO\Handle. IOResource isn't bad either... hmm...

nozavroni commented 7 years ago

I went ahead and changed the name of the IO\Resource class to IO\StreamResource but I'm still not 100% sure on the name. I'm still considering IO\Res, IO\Handle, IO\ResHandle or IO\StreamRes

nozavroni commented 7 years ago

Because I haven't yet committed to any particular class name (I changed it from Resource to StreamResource, but I'm still not married to that name) and like I said, IO\Res, IO\StreamRes, IO\RSource, IO\StrmRes, IO\Resourse, and IO\Handle all look pretty good as well (well maybe not Resourse but the rest for sure) I am closing this issue, but only so that it shows up in my list of completed tickets for this milestone. But to remind myself to revisit this issue before pushing this release, I'm going to add a note about it to the Milestone description.