nozavroni / csvelte

🕺🏻 CSV and Tabular Data library for PHP
http://phpcsv.com/
Other
6 stars 0 forks source link

Add a phpcs.xml and implement CS fixes #153

Closed nozavroni closed 7 years ago

nozavroni commented 7 years ago

Using either styleci.io or by manually running a CS fixer, integrate some sort of coding style fixer into your continuous integration process. I want my code to be more consistent. I also want something to keep an eye on my more egregious coding habits (one-liner conditionals, shitty docblocks, etc.).

nozavroni commented 7 years ago

I have begun working on, at least, my phpcs.xml.dist file. If I'm going to use this thing, I want to do more than just specifying PSR-2. I have my own style. I don't MIND some of the things that PSR2 and other standards bitch about. Then again, some of my habits could probably do with some clean-up (the one-line conditional bodies can probably go). I want to really customize my phpcs ruleset or not use it at all. Anyway, this is the result of my first run. It's not perfect. Lines 683-691 seem wrong for instance. But I'll need to test to be sure. Also, I want to add some of the comment formatting and array/variable definition alignment stuff. Also probably docblock requirements like parameter definitions and return values. Method/function summary and descriptions should be required. Variables should only require a short summary and type. Stuff like that. This is really a nice-to-have though so I'm going to come back to it later. phpcs.diff.txt

nozavroni commented 7 years ago

I just went ahead and use StyleCI instead. So this is moot.