search

nozavroni / csvelte

🕺🏻 CSV and Tabular Data library for PHP
http://phpcsv.com/
Other
6 stars 0 forks source link

getKeyAt() should throw different exception #185

Closed nozavroni closed 6 years ago

nozavroni commented 6 years ago

In the old collection library, when getKeyAt (and its ilk) were requested with a position that did not exist, it threw an OutOfBoundsException. I think this may be more appropriate than the RuntimeException it throws right now. Look into this and find out if this is an appropriate use of OutOfBoundsException or if not, if there is a better one to use.

nozavroni commented 6 years ago

Move this issue to https://github.com/nozavroni/collect