Bug fix for issue #191 - Githubissues

nozavroni / csvelte

🕺🏻 CSV and Tabular Data library for PHP

http://phpcsv.com/

Other

6 stars 0 forks source link

Bug fix for issue #191 #192

Closed nozavroni closed 5 years ago

nozavroni commented 5 years ago

I'm really not thrilled about the changes I had to make to get this fixed. In order to make this work I had to take what I felt like was a very clean, very easy-to-understand iterator and complicated it quite a bit. I would like to address this in the future to try to simplify and improve the changes I made. But I've spent enough time on this for now, so I'm committing and moving on.

See #191

nozavroni commented 5 years ago

Oops! Wrong branch this is supposed to merge into v0.3 release branch. Closing this PR!

coveralls commented 5 years ago

Coverage decreased (-4.2%) to 92.262% when pulling 82fe0f86253b1b3b4bb5b774b60660323d76abef on bugs/191 into 01c55b3fb9c0d85f9bf17e2c3f09da4ce44e55bf on master.