search

nozavroni / csvelte

🕺🏻 CSV and Tabular Data library for PHP
http://phpcsv.com/
Other
6 stars 0 forks source link

Parameter order on Readable::readLine() #21

Closed deni-zen closed 8 years ago

deni-zen commented 8 years ago

I think it might make more sense to switch the parameter order on the Readable::readLine() interface from $maxLen, $lineTerminator to $lineTerminator, $maxLen because I've found that I rarely care about $maxLen but often find the need to change $lineTerminator. That may be because my use cases are wildly different than my end users though... think about it.

nozavroni commented 8 years ago

This will be rendered moot by issue #96 since Readable::readLine() has been changed to Readable::fgets() (or possibly getCurrentLine())

nozavroni commented 8 years ago

Fixed by several refactors