search

nozzle / nzScrollbar

A featherweight replacement scrollbar directive for angularJS
3 stars 4 forks source link

Cross-browser support #2

Closed cosme-benito closed 9 years ago

cosme-benito commented 9 years ago

There seems to be issues in some of the major browsers :(

Chrome: works okay

IE 11: scrollbar doesn't show up but it works using mouse scroll wheel

Firefox 34: scrollbar doesn't show up, mouse wheel is extremely slow

tannerlinsley commented 9 years ago

I'll take a look at both. Firefox I think uses a different multiplier in their scroll event that we may need to to compensate for.

cosme-benito commented 9 years ago

Thanks a lot for your feedback and fast replies :)

tannerlinsley commented 9 years ago

No problem. If your in a PC, try to see if you can gather any specifics in Ie. I'm on my Mac and out of browserstack credits

tannerlinsley commented 9 years ago

@cosme-benito I've published a a new branch (d1ed9f8955320795a09a7db2a819f2425bad781b) for cross-browser support and a couple of other fixes. If it fixes your errors (and the future tests I need to still write ;), let me know and I'll merge to master.

Edited: I had not made the fix to the updated master. Now using latest pull.

cosme-benito commented 9 years ago

Scroll shows fine in all major browsers (Chrome, IE, Firefox) but Firefox still has extremely slow scroll speed.

Will test on iPad as soon as possible.

tannerlinsley commented 9 years ago

Hmmm strange. I'll dig some more later today

tannerlinsley commented 9 years ago

@cosme-benito Try the latest Cross-Browser-Fixes commit. It should feel better in firefox, especially with a physical mousewheel. Improved some overall accuracy issues as well.

cosme-benito commented 9 years ago

Looks good.

tannerlinsley commented 9 years ago

Well, unless you find any more bugs or need to make some adjustments, I'll merge and close this for now.

cosme-benito commented 9 years ago

Thanks again for the continuing support.

kotmatpockuh commented 9 years ago

Do not forget!

display: (containerHeight) / innerHeight >= 1 ? 'none' : 'initial'

will to work in ie10