nozzle / nzTour

Touring and on-boarding made simple for AngularJS -
http://nozzle.github.io/nzTour/
MIT License
73 stars 24 forks source link

A couple error fixes and some housekeeping #19

Closed masimplo closed 8 years ago

tannerlinsley commented 8 years ago

I trust you on this one. On Wed, Dec 16, 2015 at 6:00 PM Michael notifications@github.com wrote:


You can view, comment on, or merge this pull request online at:

https://github.com/nozzle/nzTour/pull/19 Commit Summary

  • fixes elem[_addEventListener] is not a function error
  • basic linting
  • throwing errors would break promise chain. Rejections should be used instead.
  • mask colour applied using ng-style instead of jquery
  • we should pollute angular object with custom methods to avoid future namespace clashes
  • fixes Cannot read property 'target' of undefined when scrolling in step description
  • fixed a few promise anti-patterns

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/nozzle/nzTour/pull/19.

masimplo commented 8 years ago

Awesome. BTW here is an explanation on the change in promises 1 and 2.

Also please make a release so that the latest code is available through bower