Closed masimplo closed 8 years ago
I trust you on this one. On Wed, Dec 16, 2015 at 6:00 PM Michael notifications@github.com wrote:
You can view, comment on, or merge this pull request online at: https://github.com/nozzle/nzTour/pull/19 Commit Summary fixes elem[_addEventListener] is not a function error basic linting throwing errors would break promise chain. Rejections should be used instead. mask colour applied using ng-style instead of jquery we should pollute angular object with custom methods to avoid future namespace clashes fixes Cannot read property 'target' of undefined when scrolling in step description fixed a few promise anti-patterns File Changes M dist/nz-tour.js https://github.com/nozzle/nzTour/pull/19/files#diff-0 (229) M dist/nz-tour.min.js https://github.com/nozzle/nzTour/pull/19/files#diff-1 (2) M src/nz-tour.js https://github.com/nozzle/nzTour/pull/19/files#diff-2 (198) Patch Links: https://github.com/nozzle/nzTour/pull/19.patch https://github.com/nozzle/nzTour/pull/19.diff — Reply to this email directly or view it on GitHub https://github.com/nozzle/nzTour/pull/19.
You can view, comment on, or merge this pull request online at:
https://github.com/nozzle/nzTour/pull/19 Commit Summary
File Changes
Patch Links:
— Reply to this email directly or view it on GitHub https://github.com/nozzle/nzTour/pull/19.
Awesome. BTW here is an explanation on the change in promises 1 and 2.
Also please make a release so that the latest code is available through bower
I trust you on this one. On Wed, Dec 16, 2015 at 6:00 PM Michael notifications@github.com wrote: