nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
742 stars 308 forks source link

Added IServiceFactory<T> + Refactor DI #1010

Closed adearriba closed 6 months ago

adearriba commented 7 months ago

Hi,

Based on my suggestion I did the changes to the factories: https://github.com/nozzlegear/ShopifySharp/issues/1003. I also updated DI to automatically include all factories based on the generic interface and updated the DI test case to test all interfaces are added correctly.

Let me know your thoughts and I hope this helps you in some way. 😄 I've use a lot ShopifySharp and I'm glad to be of help.

nozzlegear commented 6 months ago

This is awesome @adearriba! Thanks a ton for doing this, it makes maintaining the service factories and DI package a lot simpler.

adearriba commented 6 months ago

Happy to help! You are welcome 😃