search

nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
742 stars 308 forks source link

Update AssignedFulfillmentOrderService to produce ListResult #1012

Closed mperator closed 5 months ago

mperator commented 6 months ago

The current version (master) does not return ListResults for the assigned_fulfillment_orders endpoint.

With the default limit of 50 items per response this behavior cause an error if more than 50 items exists as always the same items will be returned.

7Kronos commented 5 months ago

Hi @mperator @nozzlegear, Any update on this ? Needing this, tell me if I can help 👍

mperator commented 5 months ago

Hi @mperator @nozzlegear, Any update on this ? Needing this, tell me if I can help 👍

Hi @7Kronos, I am contributing the first time and not sure how the process is working here.

nozzlegear commented 5 months ago

Sorry, I missed the notification for this pull request!

nozzlegear commented 5 months ago

Okay, got this merged in! The PR had some conflicts that needed to be fixed due to your fork of ShopifySharp being out of date, but I was able to cherry-pick your commit and apply it directly to ShopifySharp after a few small conflict fixes. Here are your changes in ShopifySharp's master branch. I'm going to close this PR as the changes are now merged in, once the tests are done running I'll publish a new version to Nuget.

Thanks for contributing @mperator!