search

nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
742 stars 308 forks source link

FIX: Added SendAsync missing methods to IGraphService #1015

Closed adearriba closed 6 months ago

adearriba commented 6 months ago

Hi @nozzlegear

I added SendAsync methods that were missing in IGraphService interface to solve this issue https://github.com/nozzlegear/ShopifySharp/issues/1007

I'm needing them so I just added them and make the PR to help.

Best, @adearriba

nozzlegear commented 6 months ago

Awesome, thank you very much @adearriba! I made a quick change to hide two of the new interface methods unless the package is installed in a .NET 6.0 or greater project. Everything else is perfect, I've merged it in and will publish today.

adearriba commented 6 months ago

Hi @nozzlegear could you push this to nugget as 6.13.1 so it's not necessary to do a cast to reach SendAsync methods? Right now with 6.13.0 we need to do:

var response = await ((GraphService)graphService).SendAsync<ProductVariantConnection>(request, 5, ct);
nozzlegear commented 6 months ago

Oops, my bad! I meant to merge another pull request and then publish all of the changes in a new release, but I got distracted and never finished that. I’ll create a new release tomorrow as soon as I’m back home!

-- Joshua Harms

On Feb 15, 2024, at 02:52, Alejandro de Arriba @.***> wrote:

Hi @nozzlegear could you push this to nugget as 6.13.1 so it's not necessary to do a cast to reach SendAsync methods? Right now with 6.13.0 we need to do: var response = await ((GraphService)graphService).SendAsync(request, 5, ct); — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>