search

nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
733 stars 303 forks source link

Skipping failing test that goes into infinite loop #1034

Closed clement911 closed 4 months ago

clement911 commented 4 months ago

@nozzlegear I had to skip this test because it doesn't work anymore. This caused the build to go into an infinite loop.

nozzlegear commented 4 months ago

Interesting , thanks! I wonder if they changed something recently. I’ve been planning to update tests like this one to use mocks and give it the json we expect Shopify to return, maybe I’ll do that for this case to ensure the test is still testing the error parsing.

Glad you found the issue so quickly!

clement911 commented 4 months ago

Also I noticed that this test was calling the API without any API version in the URL, so Shopify defaults to the oldest supported version.