nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
747 stars 309 forks source link

RefundLineItem SubTotalTaxSet - copypaste issue? #1071

Open nyan-cat opened 4 months ago

nyan-cat commented 4 months ago

RefundLineItem has this decimal property:

[JsonProperty("total_tax")]
public decimal? TotalTax { get; set; }

And PriceSet version of it:

[JsonProperty("total_tax_set")]
public PriceSet TotalTaxSet { get; set; }

All good so far. Also it has this decimal property:

[JsonProperty("subtotal")]
public decimal? SubTotal { get; set; }

And this PriceSet version:

[JsonProperty("subtotal_set")]
public PriceSet SubTotalTaxSet { get; set; }

JSON name is subtotal_set, but C# name is SubTotalTaxSet. Is that a typo? Shouldn't it be just SubTotalSet, which is not related to taxes?

nozzlegear commented 4 months ago

Hey, good catch! It does look like a copy/paste issue. I'll get this fixed!