nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
754 stars 313 forks source link

Create/Update product with 4k images dont throw exceptions or errors. #733

Open alexwieler opened 2 years ago

alexwieler commented 2 years ago

Hi Folk, We installed the last ShopifySharp version (5.15.0) and now when we send images in high resolution we dont receive any exception, in the past we used to receive an exception with an specific message (20megapixel image blabla) and in that case we resize the image and send it again. But now we dont receive any exception, any message, etc. The product that we sent is is returned without that bigs images.

Do you know what happened, where was the change? I can of course implement a validation with the result product but will not be a happy code (with others ugly things we made in the code to make this work)

Could you help us? Thanks.

Screen Shot 2022-04-12 at 21 31 14
nozzlegear commented 2 years ago

Hi @alexwieler, it looks like your issue slipped past me. Sorry about that. Did you ever figure this one out, or is it still an issue for you? I've noticed strange behavior around image and asset uploads with Shopify in the past, so it doesn't surprise me that it was behaving weirdly.