search

nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
758 stars 313 forks source link

What's the plan to support Shopify API 2022-10 #814

Open bobhuang1 opened 1 year ago

bobhuang1 commented 1 year ago

First of all, I love ShopifySharp, makes coding for Shopify in .NET much simpler and easier.

The question, if there is a plan to support Shopify API 2022-10? This version has many new changes that I would need to implement like the order.purchasingEntity object.

Thanks!

nozzlegear commented 1 year ago

Hey @bobhuang1! My plan right now is to release 2022-07 within the next week or so, and then start working on 2022-10 soon afterwards. It has a lot of implications for existing apps, so 2022-10 might be justify a ShopifySharp 6.0 release but I haven't quite finalized that decision yet. You'll hear more soon!

bobhuang1 commented 1 year ago

Thanks much @nozzlegear , looking forward to the new version 6 of ShopifySharp. Keep up the good work!

clement911 commented 1 year ago

@nozzlegear I thought I'd reopen this since we haven't agreed on a plan to tackle the upgrade to API version 2022-10. As a reminder, 2022-10 is quite special because of protected customer data.

I think some users will want more time to get ready for it, but some others (myself included) would like to be able to use 2022-10 and higher ASAP.

I think we could commit changes to use API version 2022-10 (or above) to the master branch . At the same time, we would also increment ShopifySharp's major version to make it clear that this is potentially a breaking change (if your app uses customers resources and hasn't been approved by Shopify to using customers fields).

In addition, we could also potentially make a fork of the current master branch to a new branch called '2022-07-fixes'. This would allow us to release some fixes and improvements to users of 2022-07 who are not ready to upgrade yet. As far as the build process, is it straight forward to publish nuget packages from 2 different branches?

What do you think?

bobhuang1 commented 1 year ago

@clement911 I would choose the second option and allow users who are not ready to upgrade yet to still be able to receive updates and fixes, though it will create more workload for you guys! Thanks!

clement911 commented 1 year ago

@nozzlegear any thoughts on this?

nozzlegear commented 1 year ago

@clement911 I think that sounds great! Let's do that. I've just updated the 2022-07 branch with the latest changes from master, so we'll use that for fixes to ShopifySharp 5.x. We can use the master branch for ShopifySharp 6.0 and 2022-10. I'll open up a new issue to track all of the changes that need to go into that before publishing it to Nuget.

As far as the build process goes, I'll need to update the build script to handle both branches but it should be doable! I'll take a look at that soon.

nozzlegear commented 1 year ago

844