search

nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
757 stars 313 forks source link

The request for the API is missing properties #897

Closed smart222zx closed 1 year ago

smart222zx commented 1 year ago

The request for FulfillmentService.CreateAsync is missing the origin_address, causing the request to fail.

smart222zx commented 1 year ago

I am writing regarding an issue I encountered while using the Shopify API for the “Creates a Fulfillment” request.

According to the latest version of the API documentation, it is mandatory to include the “origin_address” object when making the aforementioned request.

I understand the importance of providing accurate and complete information for successful fulfillment requests. Therefore, I would like to rectify this issue by ensuring that the “origin_address” object is correctly included in my future request.

Could you please provide me with the necessary details and format for the “origin_address” object? This will greatly assist me in updating my request to meet the API requirements accurately.

I apologize for any inconvenience caused and appreciate your kind assistance in resolving this matter promptly. Thank you for your attention to this matter.

nozzlegear commented 1 year ago

Hey @smart222zx, the Fulfillment class does have the origin_address property on it, but we name it OriginAddress. Here's a link to the property.

smart222zx commented 1 year ago

Hey @smart222zx, the Fulfillment class does have the origin_address property on it, but we name it OriginAddress. Here's a link to the property.

Sorry, my intention was that the FulfillmentShipping.cs is missing the origin_address.

nozzlegear commented 1 year ago

Ah I see! You're right, it looks like they've added that at some point. I'll get that added.

nozzlegear commented 1 year ago

@smart222zx Okay, I've added this in ShopifySharp v6.2.0 on Nuget!