nozzlegear / ShopifySharp

ShopifySharp is a .NET library that helps developers easily authenticate with and manage Shopify stores.
https://nozzlegear.com/shopify-development-handbook
MIT License
742 stars 309 forks source link

"SmartRetryExecutionPolicy" has this been deprecated #946

Closed BasitBulbulia closed 10 months ago

BasitBulbulia commented 10 months ago

Does SmartRetryExecutionPolicy not exist anymore if so has it been replaced by what?

I am using .net vb and usually did a call like this :-

Public Async Function GetProductCount() As Threading.Tasks.Task(Of Integer)
    Try
        Dim productService = New ProductService(urlFromUser, shopAccessToken)
        'set the RetryExecutionPolicy to handle the API limits
        productService.SetExecutionPolicy(New SmartRetryExecutionPolicy())

        'get the total count of products
        Dim productCount As Integer = Await productService.CountAsync()

        Return productCount
    Catch ex As Exception
        MsgBox(ex.Message)
        Return Nothing
    End Try
End Function
nozzlegear commented 10 months ago

Hey! It’s been replaced by the LeakyBucketExecutionPolicy. It does everything the smart retry policy did, plus it handles graphql requests as well.

-- Joshua Harms

On Tue, Oct 24, 2023, at 16:49, BasitBulbulia wrote:

Does SmartRetryExecutionPolicy not exist anymore if so has it beenn replaced by what?

— Reply to this email directly, view it on GitHub https://github.com/nozzlegear/ShopifySharp/issues/946, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASOE7CVJGMBNUEEJFV4OIDYBAZV7AVCNFSM6AAAAAA6OLO7S6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DAMJTGI3DGNI. You are receiving this because you are subscribed to this thread.Message ID: @.***>