np-eazy / Pentaquad

3 stars 1 forks source link

Refactor CollisionSet-related code for better code reuse #13

Closed np-eazy closed 1 year ago

np-eazy commented 1 year ago

Refactor to Rust: Still debating this one, but should probably be figured out soon so it doesn't become more of a pain in the ass later. The game itself is lightweight enough to run on any language, so it will come down to what kind of graphics we decide to add.

Double-Check Piece Collision Detection: we should only be querying as many blocks as there are in the single Piece for both the boundaries and already-placed blocks so the game can run just as fast on any-size board

np-eazy commented 1 year ago

Already got a headstart on this in PR #33 with the new CollisionSets class. How I think this should be continued is as follows:

np-eazy commented 1 year ago

Not needed since I'm deciding to keep the game design simple and based on what's already here.

This issue was also to address inefficiencies in calculating collisions, but for the sake of implementation and the requirements of this web game, I've found an improvement which is not as optimal as using a PIDSet in CoreState but still far better than original. #41