Node v11 added as a dependency in v2.7.0

np-maintain / global-tunnel

Global HTTP & HTTPS tunelling agent - hard fork of https://github.com/SalesforceEng/global-tunnel

BSD 3-Clause "New" or "Revised" License

118 stars 20 forks source link

Node v11 added as a dependency in v2.7.0 #27

Closed sstone1 closed 5 years ago

sstone1 commented 5 years ago

global-tunnel-ng@2.7.0 has added a dependency on node@^11.1.0 in the following commit:

https://github.com/np-maintain/global-tunnel/commit/aeb7fd0a2a4cd3c2a83f26b0ca7bd121ace6cffc#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R16

This puts node v11 into the PATH which looks to have broken us in multiple places when using node v8, as the v11 binary seems to gets resolved from the PATH.

If this dependency is required, it should be added in a semver breaking change (e.g. v3).

sstone1 commented 5 years ago

@MarcoScabbiolo can you look at this please?

MarcoScabbiolo commented 5 years ago

Solved and published in 2.7.1 , sry.

sstone1 commented 5 years ago

Thanks for the quick resolution @MarcoScabbiolo!