Add NO_PROXY environment variable support

np-maintain / global-tunnel

Global HTTP & HTTPS tunelling agent - hard fork of https://github.com/SalesforceEng/global-tunnel

BSD 3-Clause "New" or "Revised" License

118 stars 20 forks source link

Add NO_PROXY environment variable support #38

Open carlost opened 5 years ago

carlost commented 5 years ago

I ran into this issue when using yo which recently included global-tunnel-ng.

globalTunnel.initialize config rules will automatically configure use of a proxy if it runs across relevant env vars or npm config. Unfortunately, it doesn't take into account the presence of any no proxy configuration.

This can result in errors when attempting to connect to hosts found in FRONT of the proxy.

it would be great if mixinProxying would check the host against the no proxy config before redirecting the connection to the proxy.

MarcoScabbiolo commented 5 years ago

The NO_PROXY environment variable is used as a comma separated list of hosts to black-list from proxying.

The idea is to support this blacklist in 3 scenarios:

A new option to pass to initialize called ignoredHosts
ignoredHosts will default to the contents of NO_PROXY
A new option ignoreNoProxyEnvironmentVariable will disable reading from NO_PROXY and assigning it as the default value for ignoredHosts

As @carlost said, mixinProxying will need to check the host against this black-list.

ghost commented 5 years ago

Hello, Are there any predictions when this option can be introduced?

MarcoScabbiolo commented 5 years ago

Hello @maximd8 I don't have the time to get this working, feel free to try it yourself and submit a PR