np43 / qextserialport

Automatically exported from code.google.com/p/qextserialport
Other
0 stars 0 forks source link

Doesn't compile on linux #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Clone the repository
2. Try to compile it under linux

What is the expected output? What do you see instead?
Lots of compilation issues.

What version of the product are you using? On what operating system?
Cloned the repository today. Ubuntu 9.04.

Please provide any additional information below.
I've fixed the compilation issues and attached the diff. Basically the
previous commit to the enumerator wasn't completed properly. Bad variable
names, ifdefs and includes (as seen in diff). 

I haven't actually looked at the logic of the code yet, if I encounter any
more issues while using this I will flag another issue. Will also include a
diff if I have fixed it.

Original issue reported on code.google.com by brock.tr...@gmail.com on 2 Feb 2010 at 3:52

Attachments:

GoogleCodeExporter commented 9 years ago
Sorry bout that - just pushed a fix.

It would probably be nicer to split the implementations into platform specific 
files...I'll try to do that soon.

Original comment by lst...@gmail.com on 3 Feb 2010 at 5:07

GoogleCodeExporter commented 9 years ago
Yeah that sounds like a really good idea. The way the ifdefs are at the moment 
it
makes the code really hard to navigate.

Original comment by brock.tr...@gmail.com on 4 Feb 2010 at 12:24