search

npadmana / DistributedFFT

6 stars 2 forks source link

Elegance cleanup #29

Closed npadmana closed 5 years ago

npadmana commented 5 years ago

WIP.

npadmana commented 5 years ago

cc @ronawho.

I'm not quite done, but I've cleaned up a lot of the old detritus and updated some of the test cases, including one to catch bugs with xy mixup. Most of this is trivial, but it would be useful if you could look over this. I think these are pretty orthogonal to your changes, so merging should be straightforward.

ronawho commented 5 years ago

There are some remaining calls to warmUpPlanner in ft.chpl and other example tests. I don't know much about FFTW, so this is likely wrong -- I thought warmupplanner also took care of optimizing the plan. Do we just do that during the first call now and info is retained for future runs?

edit

Oh, duh -- I missed that warmup was only used for non-transposed stuff, nevermind. In that case, ft.chpl and others won't work because they're calling non-transposed routines that don't exist anymore.

ronawho commented 5 years ago

As a selfish request, my rebase is a lot easier if adc8e46 isn't added yet.

Beyond the tests that still use non-transposed stuff, this looks great to me.