search

npadmana / DistributedFFT

6 stars 2 forks source link

Make DistributedFFT index neutral #67

Closed ronawho closed 4 years ago

ronawho commented 4 years ago

Chapel 1.22 is changing to 0-based tuples. Update to make this code index-neutral so it will work with 1.20, 1.21, and 1.22.

ronawho commented 4 years ago

cc @npadmana, this works, but could probably use some cleanup, specifically around the code that's doing (dim1, dim2) = dom.dims();. I don't completely grok the setupPlan/parDim code, so I'm happy to leave that to you.

npadmana commented 4 years ago

I think the parDim code might be made more readable/maintainable by making it eg. an enum. I'll do that after merging these changes in. Thanks for updating this and in particular, for making it work with 1.20-1.22.