search

nparashuram / cordova-plugin-browsersync

BrowserSync Plugin for Cordova
110 stars 69 forks source link

Fix live reload not working on Windows #9

Closed asselin closed 8 years ago

asselin commented 8 years ago

patcher.getWWWFolder() was returning the path with backslashes on Windows, but some callers of the code assumed it returned slashes, and used it to form URLs.

I modified patcher.getWWWFolder() to always return the path with slashes, and any caller that needs a filesystem path will run it through path.join() to convert to the proper OS delimiter

asselin commented 8 years ago

This fixes issue #6

axemclion commented 8 years ago

@asselin Instead of changing the API that is consumed by projects like the virtual device wall, I fixed the routes in https://github.com/nparashuram/cordova-plugin-browsersync/commit/357ad7c6565db023461433c6357d324a6fdcc6b7. Do you think this will work ?

You should be able to install the master branch of the plugin on windows and try it out.

axemclion commented 8 years ago

@asselin, Closing this PR as it is outdated. If the fix mentioned above does not work, please re-open the PR.