search

npathai / hamcrest-optional

Matchers for JDK 8 Optional
MIT License
42 stars 3 forks source link

Don't extend the utility class itself. #3

Closed stefanbirkner closed 8 years ago

stefanbirkner commented 8 years ago

Classes that provide Hamcrest matchers are usually utility classes that don't implement an interface. E.g. org.hamcrest.CoreMatchers and org.hamcrest.Matchers.

stefanbirkner commented 8 years ago

The coverage decreased because of the private constructor that prevents creating an object of type OptionalMatcher.

npathai commented 8 years ago

Thanks for your fix @stefanbirkner . I will be releasing it on maven central soon. Was a bit busy lately.

stefanbirkner commented 8 years ago

I rebased this pull request against master. It can now be merged.