npct / pct-shiny

The Shiny map for Local Authorites
GNU Affero General Public License v3.0
24 stars 14 forks source link

Debugging Liverpool #101

Closed Robinlovelace closed 8 years ago

Robinlovelace commented 8 years ago

This is almost certainly a data issue, so my responsibility to fix.

Just that I've generated data for Liverpool using updated scripts and it seems to fail, but I've no idea why:

data_dir <- "pct-data/Liverpool-City-Region/"

z <- readRDS(file.path(data_dir, "z.Rds"))
l <- readRDS(file.path(data_dir, "l.Rds"))
rf <- readRDS(file.path(data_dir, "rf.Rds"))
rq <- readRDS(file.path(data_dir, "rq.Rds"))
rnet <- readRDS(file.path(data_dir, "rnet.Rds"))

plot(z)
plot(l, col = "blue", add = T)
plot(rf, col = "red", add = T)
plot(rq, col = "green", add = T)
plot(rnet, col = "grey", add = T)

rplot

Note: I've added some basic debugging code but I think we can add more - any ideas @nikolai-b and @usr110

Robinlovelace commented 8 years ago

Almost there - need to remove dependency on 'www' folder in the startingCity directory - @nikolai-b

Robinlovelace commented 8 years ago

@nikolai-b fix the reliance on model-output in pct-shiny too

Robinlovelace commented 8 years ago

Another way of stating the problem: make it work for Shropshire! http://geo8.webarch.net/Shropshire/

Robinlovelace commented 8 years ago

Great work.

We agreed to push to production unless there's a reason not to. Pushed to production now.