npct / pct-shiny

The Shiny map for Local Authorites
GNU Affero General Public License v3.0
24 stars 14 forks source link

Lines tab show an error when route-network is selected #323

Closed usr110 closed 8 years ago

usr110 commented 8 years ago

lines-tab-route-network

usr110 commented 8 years ago

Either the data table for rnet should be different from those of lines, or column names (as well as required data) of rnet should be made the same as lines data. At the moment, they're quite different: Rnet columns

colnames(readRDS("../pct-data/cambridgeshire/rnet.Rds")@data) [1] "bicycle" "govtarget_slc" "gendereq_slc" "dutch_slc" "ebike_slc"
[6] "bicycle_upto" "govtarget_slc_upto" "gendereq_slc_upto" "dutch_slc_upto" "ebike_slc_upto"
[11] "Singlezone"

As for the naming conventions, I thought we had agreed that all variable names should be in lower case (case in point: Singlezone)

Lines columns

colnames(readRDS("../pct-data/cambridgeshire/l.Rds")@data) [1] "msoa1" "msoa2" "all" "light_rail"
[5] "train" "bus" "taxi" "motorbike"
[9] "car_driver" "car_passenger" "bicycle" "foot"
[13] "other" "is_two_way" "dist" "id"
[17] "cirquity" "geo_label_d" "geo_label_o" "govtarget_slc"
[21] "govtarget_sic" "govtarget_slw" "govtarget_sld" "govtarget_sid"
[25] "gendereq_slc" "gendereq_sic" "gendereq_slw" "gendereq_sld"
[29] "gendereq_sid" "dutch_slc" "dutch_sic" "dutch_slw"
[33] "dutch_sld" "dutch_sid" "ebike_slc" "ebike_sic"
[37] "ebike_slw" "ebike_sld" "ebike_sid" "govtarget_sldeath_heat" [41] "govtarget_slvalue_heat" "govtarget_sideath_heat" "govtarget_sivalue_heat" "gendereq_sldeath_heat" [45] "gendereq_slvalue_heat" "gendereq_sideath_heat" "gendereq_sivalue_heat" "dutch_sldeath_heat"
[49] "dutch_slvalue_heat" "dutch_sideath_heat" "dutch_sivalue_heat" "ebike_sldeath_heat"
[53] "ebike_slvalue_heat" "ebike_sideath_heat" "ebike_sivalue_heat" "govtarget_slco2"
[57] "govtarget_sico2" "gendereq_slco2" "gendereq_sico2" "dutch_slco2"
[61] "dutch_sico2" "ebike_slco2" "ebike_sico2" "geo_label1"
[65] "geo_label2" "dist_fast" "dist_quiet" "time_fast"
[69] "time_quiet" "distq_f" "avslope" "avslope_q"
[73] "clc"

Robinlovelace commented 8 years ago

I think we should just say 'No lines available' as they're not really lines. Well spotted though @usr110 - happy for you to fix this if it's easy.

Robinlovelace commented 8 years ago

Also remove the download as .csv for Route Network.

usr110 commented 8 years ago

@Robinlovelace I don't see an option for CSV for route network

csv-route-network

Robinlovelace commented 8 years ago

Fast fix Ali!