search

npct / pct-shiny

The Shiny map for Local Authorites
GNU Affero General Public License v3.0
24 stars 14 forks source link

modification of text to line data download pages #348

Closed AnnaGoodman1 closed 8 years ago

AnnaGoodman1 commented 8 years ago

see attached for requested modification to the text of the data download page for the lines. The extra three codebooks will be added by Robin 160809_Download text.docx

usr110 commented 8 years ago

Not closing right now, as Robin needs to add codebooks there. Anna, if you get the chance, please see on the test-server (in a couple of minutes) if are you happy with the changes.

Robinlovelace commented 8 years ago

Great work @usr110. I've added codebook_rnet now: https://github.com/npct/pct-shiny/commit/009f16c8ff737c66c000af733071bf0ef0e7afa5

Note: this is not yet linked to build_regions.R - will add that now.

Robin

AnnaGoodman1 commented 8 years ago

Hi Ali, thanks for looking at this. Two/three things 1) seems to be a bug, the first paragraph is now showing the "zones" paragraph in both places, as opposed to the "lines" paragraph on the lines page 2) to improve readability, could we have a line gap between "* To get attribute data, use 'ID' field to merge with straight-line CSV file" and "No lines selected: Lines must be displayed on map" 3) is easy, but only if easy, I think readability would be further improved if the list were somewhat indented, i.e. straight lines through to "*to get attribute data..." had a few spaces before them. But don't bother if this is hard