Test shiny tidy up - Githubissues

npct / pct-shiny

The Shiny map for Local Authorites

GNU Affero General Public License v3.0

24 stars 14 forks source link

Test shiny tidy up #750

Open nikolai-b opened 5 years ago

nikolai-b commented 5 years ago

We have a lot of apps running on the test server. Can we confirm they are all needed? Fine if they are I was just a bit surprised how many!

[x] geostat
[ ] ict and ict-regional (I know about these but I don't know why there are two, are they both needed? https://github.com/ITHIM/ICT)
[ ] /meta-analyses/pa/diabetes, /meta-analyses/shiny/ and /meta-analyses/ (only /meta-analyses/shiny/ code works on the test server)
[ ] /test (doesn't seem to work...)
[ ] /pct-shiny-all-layers/
[x] /schools (I'm guessing this isn't needed now as we have included this)
[x] /nearmkt (same as schools, I'm guessing this isn't needed now)

AnnaGoodman1 commented 5 years ago

agree schools and nearmkt can be deleted. no definite knowledge of the others. thanks @nikolai-b

Robinlovelace commented 5 years ago

geostat can go. Was for this, which ended up winning the vis competition, I think: http://rstudio-pubs-static.s3.amazonaws.com/102391_8eeb5ed0dfd24ec798b37434a243f6dc.html

usr110 commented 5 years ago

Thanks @nikolai-b for looking into it. I think we need to keep both ict (England) and ict-regional, as it helps compare the two from time to time. Although England as a whole is already part of the ict-regional, but there are subtle differences in the scenarios.

Re meta-analysis, I think we need to keep all of them as well.

Re pct-shiny-all-layers, I am not sure we need it.

Robinlovelace commented 4 years ago

Has this tidy-up been done @nikolai-b ? I suspect we can close this in 2020.

nikolai-b commented 4 years ago

We still have	URL	Works
http://npct0.vs.mythic-beasts.com/meta-analyses/shiny/	:heavy_check_mark:
http://npct0.vs.mythic-beasts.com/meta-analyses/	:negative_squared_cross_mark:
http://npct0.vs.mythic-beasts.com/meta-analyses/pa/diabetes/	:negative_squared_cross_mark:
http://npct0.vs.mythic-beasts.com/test/	:heavy_check_mark:

I'd like to prune it down a bit more :smile:

Robinlovelace commented 4 years ago

:+1:

AnnaGoodman1 commented 4 years ago

none to do with me, @usr110 is the one to comment on the meta-analyses urls. If Ali happy with them going I am too.