search

npes87184 / ScreenShareTile

Take a screenshot and share it quickly from Android quick setting tile
MIT License
18 stars 2 forks source link

Use Google Play In-App Review API #7

Open npes87184 opened 4 years ago

npes87184 commented 4 years ago

https://developer.android.com/guide/playcore/in-app-review

IzzySoft commented 2 years ago

Sure you want to do that? I see 2 disadvantages there: 1) dependencies on Google/GMS (which might not be available on all devices), and 2) tainting a FOSS app with a proprietary dependency. And I doubt that's worth it :wink:

npes87184 commented 2 years ago

Thank you for your analysis.

At that time, I just thought that providing this path may increase the rating in the Google Play store without deeply checking.

IzzySoft commented 2 years ago

Increasing ratings it might – just part of the FOSS community would be a bit unhappy :wink: So if you still consider it, a good idea would be to do so only for the Play Store release – and have a separate FOSS build flavor coming without it, providing that APK here as well.

For some background: while your app is available in the closed garden of Google, there are users without access to it – so your app is also available in my repo. So be welcome to give the Play Store badge a sibling if you like :smiley: And if you can get the APK size below 10 MB again (see #9), I can keep the last 3 versions again (running on my personal resources, I have to keep some limits, which are currently 30M per app).